-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Express Lane Timeboost #2561
base: master
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,221 @@ | |||
package main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is modeled almost exactly after how cmd/val-node works
bv.bidsPerSenderInRound[bidder]++ | ||
bv.Unlock() | ||
|
||
depositBal, err := balanceCheckerFn(&bind.CallOpts{}, bidder) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we may have a bit of a race condition here.
- At time t=0, r (round)=0 bidder A issues a withdrawal. The withdrawal will finalize at r=2
- At time t=120, r=2 bidder A makes a bid on round 3.
- The validator will do a balance check here, but if it connects to a node which is 1 second behind the validator then the node will see the r=1 and think the balance is still there
- Validator accepts a bid which will fail when being submitted
Some options for getting round this would be:
a. Look for withdrawal events and take those into account when calculating the balance.
or
b. Offer a balanceAtRound(uint64 round) function on the contract, then the controlling round can be supplied to the contract and always return what it will be at that round, regardless of whether the node is behind. (The node will need to be within 60 seconds of the head, but I think that's safe to expect)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
B feels the safest here that would keep the bid validator fast. Log events are expensive to scrape especially if we scale the validators
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, will add
Roll back express_lane_service_test.go use of CalldataUnits to mean an errored tx and go back to using nil. Check for nil before dereferencing the tx when generating an error message now.
Persist Auctioneer Bid DB to S3
…eedmessage Add timeboosted information to broadcast feed
…oordinatorredis Publish Timeboost BlockMetadata to Sequencer Coordinator's redis
Timeboost Bulk BlockMetadata API
…tsfield Add a boolean field to tx receipt object indicating if the tx was timeboosted
…etadata Bulk syncing of missing BlockMetadata
…rocessing Fix processing of transactions in expressLaneService
Background
At the time of writing, the Arbitrum sequencer is centralized and offers a first-come, first-serve transaction ordering policy. Txs have a current delay of approximately 250ms, which is the time the sequencer takes to produce an ordered list of txs to emit in the form of an L2 block. The current policy does not handle MEV that occurs naturally on L2, and leads to latency races offline to get faster access to the sequencer ingress server.
A new policy has been proposed, known as Express Lane Timeboost, which allows participants to bid for the rights of priority sequencing using their funds instead of hardware. In “rounds” that start at each minute mark, participants can submits bids to participate in a sealed, second-price auction for control of the next round’s “express lane”. During a round, all non-express lane txs get their first arrival timestamp delayed by some amount of time (250ms), while the express lane controller does not. The express lane controller can also choose to transfer their rights in a round.
The sequencer itself does not need to manage auctions, but simply needs to know the current round number and the address of the express lane controller for that round. From there, it can delay non-express lane txs by a nominal amount required by the protocol and validate that a tx should go through the express lane.
This PR contains the complete implementation of the system with all its components. The smart contract changes are contained within OffchainLabs/nitro-contracts/tree/express-lane-auction-all-merged.
Basic Readings
To read more about timeboost, see the AIP, the research specification, and design doc although the design doc is not fully updated yet.
Reviewing
Recommend to look at the basic readings, then look at
system_tests/timeboost_test.go
to understand how it all fits together. Then, look at bid validator and auctioneer. Finally, the sequencer changes.Features
Sequencer Changes
The changes to the sequencer hot path are quite simple. In a nutshell, if a transaction is received, it checks the following:
If timeboost is enabled AND there is an express lane controller set AND it is not coming from the express lane, it delays the tx's first arrival timestamp by some amount (250ms).
To determine if a transaction is a valid express lane tx, the sequencer runs a background thread called the
expressLaneService
, which is scraping events from the ExpressLaneAuction.sol smart contract. Express lane transactions arrive via a different sequencer endpoint than the normal one, calledtimeboost_sendExpressLaneTransaction
. The message looks as follows:The submission itself contains a tx payload, which MAY not be from the express lane controller. As long as the submission is signed by the controller, that is sufficient. Submissions have a specific nonce, called a sequence, to ensure that submissions are processed in order. This is different from the inner nonce of the payload tx. The sequencer keeps a queue of submissions and ensures it processes them in order. That is, if a submission N is received before N-1, it will get queued for submission once N arrives.
Bid Validator Architecture
Bids are limited to 5 bids per sender, but there are no limits to the number of bidders in a single round. To alleviate potential scaling concerns, we adopt a simple architecture of separating the bid validators from the auctioneer. The bid validators filter out invalid items and publish validated results to a Redis stream. In a simplified diagram, here's what it will look like:
Dependencies Added
Notes
There are several parts of this implementation that are likely not ideal:
Chicken and the egg problem in sequencer
Cannot start sequencer without express lane, but cannot deploy auction for express lane without starting sequencer. To solve this in tests, we have a separate func called
StartExpressLaneService
in the sequencer. In prod, we don’t have this issue because we can deploy the contracts before we upgrade the sequencer to timeboost, but what to do about tests?Janky prioritizing of auction resolution txs
The sequencer exposes an authenticated endpoint
auctioneer_submitAuctionResolutionTransaction
over the JWT Auth RPC for the auctioneer to use. When the auctioneer is ready to resolve an auction, it submits a tx to this endpoint, which the sequencer verifies for integrity. Then, the sequencer does the following:it immediately tries to put the item in the queue and create block. It also sets the tx as a property of the sequencer struct, and in the
createBlock
func, if this field is not nil, it gets put at the top of the queue. This is a bit janky in how it works and perhaps inefficient. Is there another way to prioritize a tx in the sequencer?Sequencer opens an http connection to itselfThe sequencer has a thread calledFixed nowexpressLaneService
which reads events from the auction smart contracts on L2 to determine express lane controllers. Because the sequencer does not havefiltersystem
API access, we instead open an RPC client against itself so we can create anethclient
to read logs and data from onchain. This doesn't seem idealReferences